Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS deployment target on M1 #102

Merged
merged 1 commit into from
Dec 9, 2022
Merged

MacOS deployment target on M1 #102

merged 1 commit into from
Dec 9, 2022

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Dec 9, 2022

lowering the deployment target across the board for all MacOS builds appears to have been a mistake. The M1 builds recently started failing by pip declaring the wheel built against the older MacOS version as not being supported.

Possibly caused by MacOS 10.4 is older than the M1 architecture.

It looks like this ticket may be related: actions/setup-python#469

@arvidn arvidn marked this pull request as ready for review December 9, 2022 13:03
@arvidn
Copy link
Contributor Author

arvidn commented Dec 9, 2022

The remaining issue with cargo publish --dry-run is related to crate versions and their dependencies, which we haven't quite settled on and solved yet.

.github/workflows/build-test.yml Outdated Show resolved Hide resolved
@altendky
Copy link
Contributor

altendky commented Dec 9, 2022

https://github.com/Chia-Network/chia_rs/actions/runs/3634470907
image

So I agree this should be addressed regardless, but are you saying these wheels are being declined by pip?

@arvidn
Copy link
Contributor Author

arvidn commented Dec 9, 2022

on CI, we build with maturin and then we do pip install --no-index --find-links wheel/target/wheels/ chia_rs, which I understand means we don't look at pypi at all, just in that directory. I ran a test where I instead specified the (one) wheel file that's in there. Then pip said it was unsupported by the platform.

@arvidn arvidn merged commit 9f67045 into main Dec 9, 2022
@arvidn arvidn deleted the m1-deployment-target branch December 9, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants