Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet protocol #100

Merged
merged 7 commits into from
Dec 22, 2022
Merged

Wallet protocol #100

merged 7 commits into from
Dec 22, 2022

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Dec 8, 2022

  • add macros to making it more succinct to define new message types and streamable types
  • add all protocol types required for the Wallet Protocol
  • add chia protocol wrapper message

This patch set is suitable to be reviewed one commit at a time.

@arvidn arvidn closed this Dec 9, 2022
@arvidn arvidn reopened this Dec 9, 2022
@arvidn arvidn marked this pull request as ready for review December 12, 2022 11:33
@arvidn arvidn force-pushed the wallet-protocol branch 2 times, most recently from 4b8cbaf to 0d9a8f1 Compare December 15, 2022 12:53
@arvidn arvidn marked this pull request as draft December 15, 2022 15:20
@arvidn arvidn force-pushed the wallet-protocol branch 3 times, most recently from f503761 to 6f418ab Compare December 15, 2022 15:44
@arvidn arvidn marked this pull request as ready for review December 15, 2022 16:43
@richardkiss
Copy link
Contributor

Long, but seems pretty straightforward. This is the kind of code that problems will be uncovered as we try it (or via integration tests).

@arvidn
Copy link
Contributor Author

arvidn commented Dec 22, 2022

yes. we won't be using these for a while. I expect to have more tests by then

@arvidn arvidn merged commit 62e6936 into main Dec 22, 2022
@arvidn arvidn deleted the wallet-protocol branch December 22, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants