-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet protocol #100
Merged
Merged
Wallet protocol #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
force-pushed
the
wallet-protocol
branch
from
December 9, 2022 08:37
e2040fd
to
40206a0
Compare
arvidn
force-pushed
the
wallet-protocol
branch
from
December 10, 2022 01:17
40206a0
to
abfe104
Compare
arvidn
force-pushed
the
wallet-protocol
branch
2 times, most recently
from
December 15, 2022 12:53
4b8cbaf
to
0d9a8f1
Compare
arvidn
force-pushed
the
wallet-protocol
branch
3 times, most recently
from
December 15, 2022 15:44
f503761
to
6f418ab
Compare
arvidn
force-pushed
the
wallet-protocol
branch
from
December 16, 2022 15:56
0d095b8
to
a86d9b9
Compare
… new streamable types. The main fix is to make all members public
arvidn
force-pushed
the
wallet-protocol
branch
from
December 19, 2022 15:43
a86d9b9
to
a4590a2
Compare
Long, but seems pretty straightforward. This is the kind of code that problems will be uncovered as we try it (or via integration tests). |
richardkiss
approved these changes
Dec 22, 2022
yes. we won't be using these for a while. I expect to have more tests by then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set is suitable to be reviewed one commit at a time.