Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some attempt at better mypy standards #28

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Some attempt at better mypy standards #28

merged 2 commits into from
Mar 16, 2023

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Mar 14, 2023

Some attempt to improve mypy settings and code standards for this repo

@emlowe emlowe marked this pull request as ready for review March 15, 2023 00:15
altendky
altendky approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a check to ci. here or in another pr. thanks@

@geoffwalmsley geoffwalmsley merged commit caa4b26 into main Mar 16, 2023
@emlowe emlowe deleted the EL.mypy-stuff branch July 23, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffwalmsley geoffwalmsley geoffwalmsley approved these changes

@altendky altendky altendky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emlowe @altendky @geoffwalmsley