Add back logging for added coins #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was removed in commit ee3dfb9 for unknown reason. A few people on keybase have learned to rely on it to check for new coins being received by their wallet. Arguably not the best way to do so but seems like a useful log output to have in general.
martomi
added a commit
to martomi/chiadog
that referenced
this pull request
Apr 25, 2021
This log has been removed from chia in the most recent versions so it serves no purpose to have the logic here. I've submitted a PR to re-add the log back, if that happens we can revert this change. Chia-Network/chia-blockchain#2720
martomi
added a commit
to martomi/chiadog
that referenced
this pull request
Apr 25, 2021
This log has been removed from chia in the most recent versions so it serves no purpose to have the logic here. I've submitted a PR to re-add the log back, if that happens we can revert this change. Chia-Network/chia-blockchain#2720
martomi
added a commit
to martomi/chiadog
that referenced
this pull request
Apr 25, 2021
This log has been removed from chia in the most recent versions so it serves no purpose to have the logic here. I've submitted a PR to re-add the log back, if that happens we can revert this change. Chia-Network/chia-blockchain#2720
|
I think this is a great idea! |
|
Yes. Please bring this back! |
mariano54
approved these changes
Apr 26, 2021
jinnatar
pushed a commit
to jinnatar/chiadog
that referenced
this pull request
Feb 5, 2023
This log has been removed from chia in the most recent versions so it serves no purpose to have the logic here. I've submitted a PR to re-add the log back, if that happens we can revert this change. Chia-Network/chia-blockchain#2720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was removed in commit ee3dfb9 for
unknown reason. A few people on keybase have learned to rely on it to
check for new coins being received by their wallet. Arguably not the
best way to do so but seems like a useful log output to have in general.