Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-1568: fix object has no attribute code errors #18665

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

wjblanke
Copy link
Contributor

@wjblanke wjblanke commented Oct 3, 2024

Purpose:

Special case code checks for WebSocketErrors

Current Behavior:

Always accesses code element even when it doesn't exist

New Behavior:

Only do it for wserror

Testing Notes:

None

@wjblanke wjblanke requested a review from a team as a code owner October 3, 2024 05:16
@wjblanke wjblanke added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Oct 3, 2024
@emlowe emlowe changed the base branch from main to release/2.4.4 October 3, 2024 14:23
@emlowe emlowe closed this Oct 3, 2024
@emlowe emlowe reopened this Oct 3, 2024
@emlowe emlowe changed the title fix object has no attribute code errors CHIA-1568: fix object has no attribute code errors Oct 3, 2024
@emlowe
Copy link
Contributor

emlowe commented Oct 3, 2024

close and reopen for CI

@emlowe emlowe closed this Oct 3, 2024
@emlowe emlowe reopened this Oct 3, 2024
@Starttoaster Starttoaster merged commit 74536ba into release/2.4.4 Oct 4, 2024
2348 of 2363 checks passed
@Starttoaster Starttoaster deleted the wserrorwjb branch October 4, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants