Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-1069] Use smarter coin selection algorithm for DAO wallet select_coins_for_asset_type #18579

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Quexington
Copy link
Contributor

This coin selection algorithm is pretty much the simplest it can be. This PR changes the function to use the canonical knapsack algorithm that all other coin selection endpoints use.

@Quexington Quexington changed the title Use smarter coin selection algorithm for DAO wallet select_coins_for_asset_type [CHIA-1204] Use smarter coin selection algorithm for DAO wallet select_coins_for_asset_type Sep 11, 2024
@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Sep 11, 2024
@Quexington Quexington marked this pull request as ready for review September 11, 2024 14:47
@Quexington Quexington requested a review from a team as a code owner September 11, 2024 14:47
Copy link

Pull Request Test Coverage Report for Build 10814044987

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.06%) to 90.928%

Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 82.28%
chia/rpc/rpc_server.py 1 88.16%
chia/data_layer/data_layer.py 2 85.8%
chia/full_node/full_node.py 9 86.37%
Totals Coverage Status
Change from base Build 10812245243: 0.06%
Covered Lines: 101698
Relevant Lines: 111811

💛 - Coveralls

@Quexington Quexington changed the title [CHIA-1204] Use smarter coin selection algorithm for DAO wallet select_coins_for_asset_type [CHIA-1069] Use smarter coin selection algorithm for DAO wallet select_coins_for_asset_type Sep 11, 2024
@markelrod
Copy link
Contributor

coverage exception ok

@cmmarslender cmmarslender merged commit 1945126 into main Sep 11, 2024
373 of 374 checks passed
@cmmarslender cmmarslender deleted the quex.dao_wallet_coin_selection branch September 11, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants