Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-1357] Correctly set start_index in create_more_puzzle_hashes #18571

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Quexington
Copy link
Contributor

Due to a logic error, start_index in the create_more_puzzle_hashes function would always be set to 0 resulting in the re-derivation of potentially many pubkeys that were not necessary. This PR correctly creates the intended variable of lowest_start_index.

@Quexington Quexington marked this pull request as ready for review September 9, 2024 20:20
@Quexington Quexington requested a review from a team as a code owner September 9, 2024 20:20
@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Sep 9, 2024
@Quexington Quexington changed the title Correctly set start_index in create_more_puzzle_hashes [CHIA-1357] Correctly set start_index in create_more_puzzle_hashes Sep 9, 2024
@emlowe
Copy link
Contributor

emlowe commented Sep 9, 2024

@arvidn This was introduced here #17991
I have a little trouble following the logic a bit, so please review

Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok!

Copy link

Pull Request Test Coverage Report for Build 10780640914

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 49 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.01%) to 90.895%

Files with Coverage Reduction New Missed Lines %
chia/wallet/util/wallet_sync_utils.py 1 86.54%
chia/timelord/timelord_launcher.py 1 69.34%
chia/full_node/weight_proof.py 2 90.66%
chia/farmer/farmer_api.py 2 94.39%
chia/server/node_discovery.py 3 80.32%
chia/server/server.py 4 82.21%
chia/server/address_manager.py 7 90.48%
chia/timelord/timelord.py 7 80.71%
chia/farmer/farmer.py 7 72.39%
chia/daemon/server.py 7 83.33%
Totals Coverage Status
Change from base Build 10777346322: -0.01%
Covered Lines: 101571
Relevant Lines: 111706

💛 - Coveralls

@pmaslana pmaslana merged commit 6a11898 into main Sep 10, 2024
374 of 375 checks passed
@pmaslana pmaslana deleted the quex.start_index_cmp branch September 10, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants