Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove initial_freeze_period from RPCs #18563

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Remove initial_freeze_period from RPCs #18563

merged 1 commit into from
Sep 6, 2024

Conversation

Quexington
Copy link
Contributor

see title

@Quexington Quexington marked this pull request as ready for review September 5, 2024 21:06
@Quexington Quexington requested a review from a team as a code owner September 5, 2024 21:06
@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Sep 5, 2024
@Quexington Quexington changed the title Remove initial_freeze_period from RPCS Remove initial_freeze_period from RPCs Sep 5, 2024
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historical lgtm

Copy link

Pull Request Test Coverage Report for Build 10728174100

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 37 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.008%) to 90.862%

Files with Coverage Reduction New Missed Lines %
chia/wallet/wallet_node.py 1 89.01%
chia/full_node/full_node_api.py 2 82.42%
chia/server/ws_connection.py 3 87.96%
chia/full_node/full_node.py 5 86.22%
chia/server/node_discovery.py 7 79.61%
chia/timelord/timelord.py 19 79.31%
Totals Coverage Status
Change from base Build 10724306143: 0.008%
Covered Lines: 101255
Relevant Lines: 111399

💛 - Coveralls

@Quexington Quexington added the ready_to_merge Submitter and reviewers think this is ready label Sep 6, 2024
@pmaslana pmaslana merged commit 3aa8706 into main Sep 6, 2024
375 of 376 checks passed
@pmaslana pmaslana deleted the quex.delete_ifp branch September 6, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants