[CHIA-1211] Use better key resolution logic in derivation commands #18516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Fixed
Quexington
changed the title
|
emlowe
approved these changes
Sep 12, 2024
emlowe
approved these changes
Sep 12, 2024
|
coverage exemption approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #16903 I made a bad change to the behavior of key functions in which I removed the resolution of a root secret key when no mnemonic file was provided. I wrongly assumed that the user would have to specify one of the two options but it's actually possible to not specify either. This PR makes sure to always resolve a secret key whenever we intend to do non_observer_derivation.