CHIA-1101: update BlockGenerator
type
#18508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Simplify and optimize code around block validation.
The
BlockGenerator
class contains the block generator for a specific block as well as the actual generators for blocks it references.This PR:
generator_refs
toList[bytes]
instead ofList[SerializedProgram]
. The only place these items are used are in generators, in CLVM. We always pass plain bytes into CLVM.FullBLock
and theBlockGenerator
. By only passing the previous generators (List[bytes]
) instead ofBlockGenerator
, we avoid copying the generator twice.Current Behavior:
Pass 2 copies of the block generator to
pre_validate_blocks_multiprocessing()
, once in theFullBlock
and once in theBlockGenerator
New Behavior:
Only pass the block generator once to
pre_validate_blocks_multiprocessing()
, in theFullBlock
. Instead of theBlockGenerator
just pass thegenerator_refs
.