[CHIA-1165] Add --valid-at/--expires-at to all CLI transaction endpoints (mostly hidden)
#18501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Added
Quexington
force-pushed
the
quex.add_timelock_args_to_cli
branch
from
3d2b1cb
to
69a917a
Compare
Quexington
changed the title
--valid-at/--expires-at to all CLI transaction endpoints--valid-at/--expires-at to all CLI transaction endpoints (mostly hidden)
github-actions
bot
added
the
merge_conflict
github-actions
bot
removed
the
merge_conflict
github-actions
bot
added
the
merge_conflict
github-actions
bot
removed
the
merge_conflict
geoffwalmsley
approved these changes
Sep 5, 2024
|
markelrod
approved these changes
Sep 5, 2024
|
coverage exception ok |
Quexington
added
ready_to_merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the option to add expiration/delayed activation to any transaction generated from the CLI. This is functionality that is available for offers at the RPC/GUI level and this PR seeks to make all transaction endpoints unified in this respect.
However, the existing wallet UX has some shortcomings that make adding this functionality difficult. For example, we do not internally mark transactions as expired when they expire, nor do we necessarily resubmit ones that are not yet valid. Without some proper though into these shortcomings, I'm hesitant to make this fully available and supported.
However, all transaction endpoints do currently have the ability to behave like offers (export the transaction to computer and not push it) so if a user wants to use it like that, I don't really see a reason why they shouldn't be allowed.
As a compromise between the tension between usefulness and UX concerns, I've decided to make the options hidden for every command except
make_offer. The options can still be used, but a user examining the help won't be able to see that they are, in fact, valid options. This means we can not really fully support the functionality, but still make it useful to adventurous users who have applications in mind.