Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request_fee_estimates #18482

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

Yakuhito
Copy link
Contributor

Currently, making a request for fee estimates using the full node protocol generates the following error:

2024-08-17T20:32:51.575 full_node chia.server.rate_limits : WARNING  Message type ProtocolMessageTypes.request_fee_estimates not found in rate limits
2024-08-17T20:32:51.578 full_node full_node_server        : ERROR    Exception: FullNodeAPI.request_fee_estimates() takes 2 positional arguments but 3 were given <class 'TypeError'>, closing connection PeerInfo(_ip=IPv4Address('127.0.0.1'), _port=0). Traceback (most recent call last):
  File "chia/server/ws_connection.py", line 431, in _api_call
  File "chia/util/api_decorators.py", line 69, in wrapper
TypeError: FullNodeAPI.request_fee_estimates() takes 2 positional arguments but 3 were given

2024-08-17T20:32:51.579 full_node full_node_server        : WARNING  Trying to ban localhost for 10, but will not ban

I traced this to the handler's decorator, which contains peer_required=True while the function doesn't accept a peer argument.

@Yakuhito Yakuhito requested a review from a team as a code owner August 17, 2024 20:48
@ChiaAutomation
Copy link
Contributor

Your commits are not signed and our branch protection rules require signed commits. For more information on how to create signed commits, please visit this page: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification. Please use the button towards the bottom of the page to close this pull request and open a new one with signed commits.

@Yakuhito
Copy link
Contributor Author

Do not trust the computer. My commits are signed.

@pmaslana
Copy link
Contributor

Do not trust the computer. My commits are signed.

@Yakuhito I apologize for the false positive in detecting unverified commits. We have fixed a bug in our monitoring bot. Please ignore the comment from ChiaAutomation.

@altendky altendky added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Aug 18, 2024
@Starttoaster Starttoaster changed the base branch from release/2.4.3 to main August 21, 2024 17:48
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok for main certainly

@pmaslana pmaslana merged commit 169a2d9 into Chia-Network:main Aug 28, 2024
1000 of 1002 checks passed
@altendky altendky mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-pr Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants