[CHIA-1129] Extract coin splitting logic from CLI -> RPC #18480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Changed
Quexington
changed the title
Quexington
force-pushed
the
quex.coin_splitting_cli_2_rpc
branch
from
66cefd7
to
65104f3
Compare
Quexington
force-pushed
the
quex.coin_splitting_cli_2_rpc
branch
from
c46f167
to
d29c99e
Compare
|
geoffwalmsley
approved these changes
Aug 27, 2024
markelrod
approved these changes
Aug 27, 2024
|
coverage exception fine |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the splitting of coins is implemented on the client side. This is overly complicated functionality to leave to a client, and using the RPCs to accomplish this ends up being a hack that causes headaches. This PR instead makes an RPC for this and only requires the client to specify parameters.