Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_puzzle_and_solution_for_coin() #18434

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Aug 9, 2024

Purpose:

Simplify the code.

Use the new, higher level, version of get_puzzle_and_solution_for_coin() from chia_rs. This drops one dependency on the DESERIALIZER_MOD (by punting it to chia_rs).

Also, pass along the ConsensusConstants passed in to get_name_puzzle_conditions(), get_puzzle_and_solution_for_coin(), get_spends_for_block() and mempool_check_time_locks().

Current Behavior:

We use the low level function get_puzzle_and_solution_for_coin() which takes parameters in serialized byte form.

New Behavior:

We use the higher level function get_puzzle_and_solution_for_coin2() which takes parameters in proper types.

@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Aug 9, 2024
@arvidn arvidn marked this pull request as ready for review August 9, 2024 13:07
@arvidn arvidn requested a review from a team as a code owner August 9, 2024 13:07
AmineKhaldi
AmineKhaldi previously approved these changes Aug 12, 2024
@arvidn arvidn requested a review from emlowe August 15, 2024 08:47
emlowe
emlowe previously approved these changes Aug 15, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Aug 15, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

…n() from chia_rs. Also, pass along the ConsensusConstants passed in to get_name_puzzle_conditions(), get_puzzle_and_solution_for_coin(), get_spends_for_block() and mempool_check_time_locks()
@arvidn arvidn dismissed stale reviews from emlowe and AmineKhaldi via ca67cd5 August 16, 2024 20:34
@arvidn arvidn force-pushed the get_puzzle_and_solution_for_coin branch from 5f73c46 to ca67cd5 Compare August 16, 2024 20:34
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Aug 16, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

Pull Request Test Coverage Report for Build 10425927286

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 26 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.04%) to 90.89%

Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.59%
chia/wallet/wallet_node.py 1 88.94%
chia/_tests/core/full_node/test_transactions.py 1 99.14%
chia/daemon/client.py 1 73.94%
chia/full_node/full_node.py 2 86.16%
chia/full_node/full_node_api.py 5 82.79%
chia/farmer/farmer.py 7 72.39%
chia/timelord/timelord.py 8 80.81%
Totals Coverage Status
Change from base Build 10423078207: 0.04%
Covered Lines: 101357
Relevant Lines: 111494

💛 - Coveralls

Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@Starttoaster Starttoaster merged commit 49a8aab into main Aug 20, 2024
374 checks passed
@Starttoaster Starttoaster deleted the get_puzzle_and_solution_for_coin branch August 20, 2024 16:23
@altendky altendky mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants