-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_puzzle_and_solution_for_coin() #18434
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…n() from chia_rs. Also, pass along the ConsensusConstants passed in to get_name_puzzle_conditions(), get_puzzle_and_solution_for_coin(), get_spends_for_block() and mempool_check_time_locks()
5f73c46
to
ca67cd5
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Pull Request Test Coverage Report for Build 10425927286Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aok
Purpose:
Simplify the code.
Use the new, higher level, version of
get_puzzle_and_solution_for_coin()
from chia_rs. This drops one dependency on theDESERIALIZER_MOD
(by punting it tochia_rs
).Also, pass along the ConsensusConstants passed in to
get_name_puzzle_conditions()
,get_puzzle_and_solution_for_coin()
,get_spends_for_block()
andmempool_check_time_locks()
.Current Behavior:
We use the low level function
get_puzzle_and_solution_for_coin()
which takes parameters in serialized byte form.New Behavior:
We use the higher level function
get_puzzle_and_solution_for_coin2()
which takes parameters in proper types.