Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-1024] Fix wallet observer mode log in while non-observer keys are present #18361

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Jul 25, 2024

There’s currently a bug where if both observer and non-observer keys are present in the keychain, an attempt to start the wallet with an observer key will result in a KeychainSecretsMissing error (the secrets are, in fact, missing on purpose).

#18234

@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jul 25, 2024
@Quexington Quexington marked this pull request as ready for review July 25, 2024 21:54
@Quexington Quexington requested a review from a team as a code owner July 25, 2024 21:54
@Quexington Quexington changed the title Fix wallet observer mode log in while non-observer keys are present [CHIA-1024] Fix wallet observer mode log in while non-observer keys are present Jul 25, 2024
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@Starttoaster Starttoaster merged commit 6a5d84d into release/2.4.3 Jul 29, 2024
1001 of 1004 checks passed
@Starttoaster Starttoaster deleted the quex.fix_observer_login branch July 29, 2024 20:17
Starttoaster pushed a commit that referenced this pull request Jul 31, 2024
[CHIA-1024] Fix wallet observer mode log in while non-observer keys are present (#18361)

Fix wallet observer mode log in while non-observer keys are present

Co-authored-by: Matt Hauff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants