Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing partial count was incorrectly incremented on solo plotNFT farming #18346

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

ChiaMineJP
Copy link
Contributor

Problem

When a farmer found a proof of space for solo plotNFT (not OG plot; farming to plotNFT but not joining any pools), missing partial count was incorrectly incremented.

Expected behavior

It should increment valid partials count.

@ChiaMineJP ChiaMineJP added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jul 23, 2024
@ChiaMineJP ChiaMineJP self-assigned this Jul 23, 2024
@ChiaMineJP ChiaMineJP requested a review from a team as a code owner July 23, 2024 15:42
Copy link
Contributor

@BrandtH22 BrandtH22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Starttoaster Starttoaster merged commit f6bfc9c into main Jul 31, 2024
372 checks passed
@Starttoaster Starttoaster deleted the cmj.fix-incorrect-missing-partials branch July 31, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants