[CHIA-902] default flags for Program.run() and Program.run_with_cost()
#18287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
changed the title
Program.run() and Program.run_with_cost()Program.run() and Program.run_with_cost()
arvidn
added
the
Changed
…ing all the most recent features, and to disallow unknown opcodes (i.e. strict mode). To have full control of which features are enabled, introduce a run2() function
Rigidity
approved these changes
Jul 10, 2024
|
looks good, thanks! |
emlowe
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make them default to enabling all the most recent features, and to disallow unknown opcodes (i.e. strict mode). To have full control of which features are enabled, introduce a run2() function
Purpose:
Running unit tests for new puzzles still uses the old CLVM rules. The only way to enable them is to resort to calling
_run(). This addresses the core issue by makingrun()andrun_with_cost()default to the most recent feature, and be the most strict.Current Behavior:
Program.run()has no soft-fork or hard-forks enabled.New Behavior:
Program.run()has all soft-forks and hard-forks enabled.