Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backwards compatibility for add_private_key #18237

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

Quexington
Copy link
Contributor

Accidentally broke this endpoint in #17792 by specifying exactly what was part of data rather than just updating the relevant part of the user's request.

@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jun 24, 2024
@Quexington Quexington marked this pull request as ready for review June 24, 2024 15:23
@Quexington Quexington requested a review from a team as a code owner June 24, 2024 15:23
@Quexington Quexington closed this Jun 24, 2024
@Quexington Quexington reopened this Jun 24, 2024
@Quexington Quexington requested a review from emlowe June 24, 2024 21:02
Copy link

coveralls-official bot commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9651527731

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 19 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.007%) to 90.882%

Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 72.57%
chia/farmer/farmer.py 1 72.23%
chia/wallet/wallet_node.py 1 88.79%
chia/daemon/client.py 1 73.33%
chia/server/ws_connection.py 3 87.96%
chia/full_node/full_node.py 5 85.7%
chia/server/node_discovery.py 7 79.96%
Totals Coverage Status
Change from base Build 9650300892: -0.007%
Covered Lines: 100223
Relevant Lines: 110216

💛 - Coveralls

@Starttoaster Starttoaster merged commit a83f59b into main Jun 24, 2024
670 of 683 checks passed
@Starttoaster Starttoaster deleted the quex.unbreak_add_private_key branch June 24, 2024 22:26
emlowe pushed a commit that referenced this pull request Jun 26, 2024
* Fix backwards compatibility for `add_private_key`

* Another backwards compatibility fix
pmaslana pushed a commit that referenced this pull request Jun 28, 2024
#18256)

Fix backwards compatibility for `add_private_key` (#18237)

* Fix backwards compatibility for `add_private_key`

* Another backwards compatibility fix

Co-authored-by: Matt Hauff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants