-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix backwards compatibility for add_private_key
#18237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Fixed
Required label for PR that categorizes merge commit message as "Fixed" for changelog
label
Jun 24, 2024
ChiaMineJP
requested changes
Jun 24, 2024
ChiaMineJP
approved these changes
Jun 24, 2024
emlowe
approved these changes
Jun 24, 2024
Pull Request Test Coverage Report for Build 9651527731Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
emlowe
pushed a commit
that referenced
this pull request
Jun 26, 2024
* Fix backwards compatibility for `add_private_key` * Another backwards compatibility fix
pmaslana
pushed a commit
that referenced
this pull request
Jun 28, 2024
#18256) Fix backwards compatibility for `add_private_key` (#18237) * Fix backwards compatibility for `add_private_key` * Another backwards compatibility fix Co-authored-by: Matt Hauff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally broke this endpoint in #17792 by specifying exactly what was part of
data
rather than just updating the relevant part of the user's request.