-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed an issue where npx --no lerna clean -f
didn't work
#18232
Conversation
Pull Request Test Coverage Report for Build 9623998655Details
💛 - Coveralls |
npx --no lerna clean -f
didnot worknpx --no lerna clean -f
didn't work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the gui pin change is unrelated? Otherwise good by me. I checked and all of the platforms ran without a gui cache hit. (maybe that's why you had the gui change in there...)
The hash key of the cache contains a ref hex string of gui submodule. |
ccfeb11
to
51615f7
Compare
Pull Request Test Coverage Report for Build 9648348830Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This fixes error in build-installer CI job.
After GUI cache is reset,
lerna
install is also removed.npx --no <command>
fails if nocomand
is found in localnode_modules
.So
npx --no lerna clean -f
diddn't work sincelerna
was removed along with cache (includingnode_modules
).This PR removes
--no
flag fromnpx
.Without
--no
option,npx
installslerna
in global cache but this global cache doesn't hurt. (even it allows version mismatch between globally installedlerna
andlerna
installed locally bynpm ci
sincelerna clean -f
only does removepackages/*/node_modules
)