Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where npx --no lerna clean -f didn't work #18232

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

ChiaMineJP
Copy link
Contributor

@ChiaMineJP ChiaMineJP commented Jun 22, 2024

This fixes error in build-installer CI job.
After GUI cache is reset, lerna install is also removed.
npx --no <command> fails if no comand is found in local node_modules.

So npx --no lerna clean -f diddn't work since lerna was removed along with cache (including node_modules).
This PR removes --no flag from npx.

Without --no option, npx installs lerna in global cache but this global cache doesn't hurt. (even it allows version mismatch between globally installed lerna and lerna installed locally by npm ci since lerna clean -f only does remove packages/*/node_modules)

@ChiaMineJP ChiaMineJP added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jun 22, 2024
@ChiaMineJP ChiaMineJP self-assigned this Jun 22, 2024
@ChiaMineJP ChiaMineJP requested a review from a team as a code owner June 22, 2024 08:02
Copy link

coveralls-official bot commented Jun 22, 2024

Pull Request Test Coverage Report for Build 9623998655

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.9%

Files with Coverage Reduction New Missed Lines %
chia/data_layer/data_store.py 1 94.37%
chia/wallet/util/wallet_sync_utils.py 1 86.54%
chia/server/node_discovery.py 1 79.96%
chia/server/server.py 1 81.46%
chia/daemon/server.py 1 83.22%
chia/data_layer/data_layer.py 2 85.32%
chia/data_layer/data_layer_wallet.py 2 91.93%
chia/rpc/rpc_server.py 3 88.04%
chia/wallet/wallet_node.py 3 88.58%
chia/_tests/core/util/test_lockfile.py 4 88.66%
Totals Coverage Status
Change from base Build 9619484401: 0.02%
Covered Lines: 100239
Relevant Lines: 110214

💛 - Coveralls

@ChiaMineJP ChiaMineJP changed the title Fixed an issue where npx --no lerna clean -f didnot work Fixed an issue where npx --no lerna clean -f didn't work Jun 23, 2024
Copy link
Contributor

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the gui pin change is unrelated? Otherwise good by me. I checked and all of the platforms ran without a gui cache hit. (maybe that's why you had the gui change in there...)

@ChiaMineJP
Copy link
Contributor Author

ChiaMineJP commented Jun 24, 2024

I think the gui pin change is unrelated? Otherwise good by me. I checked and all of the platforms ran without a gui cache hit. (maybe that's why you had the gui change in there...)

The hash key of the cache contains a ref hex string of gui submodule.
Since re-constructing cach keeps failing after updating gui pin, there has been no cache for the latest gui ref.
That's why cache was not found even when gui pin is not updated.
Please let me know if my comment does not answer your question.

@ChiaMineJP ChiaMineJP requested a review from altendky June 24, 2024 14:33
@Starttoaster Starttoaster merged commit 2e82142 into main Jun 24, 2024
360 of 366 checks passed
@Starttoaster Starttoaster deleted the cmj.fix-lerna-clean branch June 24, 2024 18:10
Copy link

coveralls-official bot commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9648348830

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.03%) to 90.903%

Files with Coverage Reduction New Missed Lines %
chia/data_layer/data_store.py 1 94.37%
chia/_tests/core/util/test_lockfile.py 1 91.09%
chia/_tests/core/full_node/test_transactions.py 1 99.11%
chia/server/node_discovery.py 1 80.5%
chia/server/server.py 1 81.46%
chia/daemon/server.py 1 83.22%
chia/data_layer/data_layer.py 2 85.32%
chia/data_layer/data_layer_wallet.py 2 91.93%
chia/rpc/rpc_server.py 3 88.04%
chia/full_node/full_node.py 3 85.75%
Totals Coverage Status
Change from base Build 9619484401: 0.03%
Covered Lines: 100244
Relevant Lines: 110214

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants