-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHIA-786] remove the original block compression #18209
Conversation
…s activated and we serialize CLVM in a more efficient way
Pull Request Test Coverage Report for Build 9596253668Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand this code well. But what I'd expect is for stuff to be deleted only, and that's pretty much what I see. And it doesn't seem to affect consensus. So from that perspective, it seems good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aok
Pull Request Test Coverage Report for Build 9858557039Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Purpose:
Now that the hard fork has activated and we serialize CLVM in a more efficient way, we can remove the old code to simplify our code.
The original compression deduplicates vanilla transactions, only in blocks made up of only such transactions.
To properly take advantage of the block references, the farmer would need to maintain an index of blocks containing popular puzzle reveals. I don't believe any of the old infrastructure is suitable to be re-worked into such feature, and it's also not on our roadmap to implement any time soon.
Current Behavior:
When farming blocks prior to the hard fork, we may replace a block of only vanilla puzzle reveals with a block reference.
New Behavior:
When farming blocks prior to the hard fork, we always produce a plain block, with all the puzzle reveals.