Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-713] Add action_scope: WalletActionScope to all tx endpoints #18127

Merged
merged 23 commits into from
Jul 16, 2024

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Jun 6, 2024

Hide whitespace to review this change.

The idea here is to pipe through an action scope to all transaction endpoints through all wallets. This action scope is not used by any of the functions yet, but since this is a self-contained change it felt good to break this off from the bigger change coming behind it. There should be no change in functionality here, just a new capability added.

@Quexington Quexington added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Jun 6, 2024
@Quexington Quexington changed the title Add action_scope: WalletActionScope to all tx endpoints [CHIA-713] Add action_scope: WalletActionScope to all tx endpoints Jun 6, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jun 6, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jun 6, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jun 6, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jun 6, 2024
@Quexington Quexington changed the base branch from quex.fix_cat_pending_change to quex.auto_claim_better_test June 10, 2024 20:11
@Chia-Network Chia-Network deleted a comment from github-actions bot Jun 10, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 11, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jul 12, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 12, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jul 12, 2024
Base automatically changed from quex.auto_claim_better_test to main July 12, 2024 19:29
@github-actions github-actions bot added merge_conflict Branch has conflicts that prevent merge to main labels Jul 12, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jul 12, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jul 12, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jul 12, 2024
@Quexington Quexington marked this pull request as ready for review July 12, 2024 20:22
@Quexington Quexington requested review from altendky and a team as code owners July 12, 2024 20:22
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 12, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jul 12, 2024
Copy link

Pull Request Test Coverage Report for Build 9913695052

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 803 of 803 (100.0%) changed or added relevant lines in 43 files are covered.
  • 16 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.06%) to 91.016%

Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 81.9%
chia/daemon/server.py 1 83.22%
chia/_tests/core/util/test_lockfile.py 2 90.69%
chia/_tests/core/test_farmer_harvester_rpc.py 2 98.02%
chia/rpc/rpc_server.py 3 87.71%
chia/server/node_discovery.py 3 78.72%
chia/full_node/full_node.py 4 85.61%
Totals Coverage Status
Change from base Build 9913133838: 0.06%
Covered Lines: 101820
Relevant Lines: 111851

💛 - Coveralls

Copy link
Contributor

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

providing required review for just the pylintrc change. thanks for keeping it focused.

@Quexington Quexington added the ready_to_merge Submitter and reviewers think this is ready label Jul 16, 2024
@Starttoaster Starttoaster merged commit 4ffb6df into main Jul 16, 2024
371 checks passed
@Starttoaster Starttoaster deleted the quex.add_action_scope_to_all_tx_endpoints branch July 16, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants