Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "CHIA-414 fixup datalayer benchmark"" #18107

Merged
merged 12 commits into from
Jun 18, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Jun 3, 2024

@altendky altendky requested a review from a team as a code owner June 3, 2024 14:19
@altendky altendky marked this pull request as draft June 3, 2024 14:19
@altendky altendky added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Tests Changes to tests labels Jun 3, 2024
@altendky altendky closed this Jun 3, 2024
@altendky altendky reopened this Jun 3, 2024
@altendky altendky marked this pull request as ready for review June 4, 2024 14:44
Copy link
Contributor

github-actions bot commented Jun 4, 2024

File Coverage Missing Lines
chia/_tests/process_junit.py 0.0% lines 192-198, 200, 202, 204-205, 207-208, 211-212, 215, 244, 247, 252, 254, 321, 324, 329, 331
chia/_tests/util/misc.py 20.0% lines 392, 394-396, 399-400, 406, 414
Total Missing Coverage
45 lines 32 lines 28%

Copy link

coveralls-official bot commented Jun 4, 2024

Pull Request Test Coverage Report for Build 9369170305

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 11 of 43 (25.58%) changed or added relevant lines in 3 files are covered.
  • 294 unchanged lines in 20 files lost coverage.
  • Overall coverage decreased (-0.04%) to 90.827%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/_tests/util/misc.py 2 10 20.0%
chia/_tests/process_junit.py 0 24 0.0%
Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.5%
chia/_tests/wallet/cat_wallet/test_cat_wallet.py 1 99.85%
chia/cmds/dao_funcs.py 1 99.72%
chia/wallet/wallet_node.py 1 88.79%
chia/wallet/util/debug_spend_bundle.py 1 99.52%
chia/_tests/wallet/test_notifications.py 1 99.32%
chia/_tests/process_junit.py 1 0.0%
chia/wallet/vc_wallet/cr_cat_wallet.py 1 97.72%
chia/wallet/dao_wallet/dao_wallet.py 1 99.89%
chia/_tests/wallet/nft_wallet/test_nft_puzzles.py 2 97.44%
Totals Coverage Status
Change from base Build 9323001297: -0.04%
Covered Lines: 99484
Relevant Lines: 109472

💛 - Coveralls

@altendky altendky requested a review from emlowe June 4, 2024 17:27
@cmmarslender cmmarslender merged commit e87d51a into main Jun 18, 2024
360 of 361 checks passed
@cmmarslender cmmarslender deleted the revert-18054-revert-17786-fixup_datalayer_benchmark branch June 18, 2024 19:25
altendky added a commit that referenced this pull request Jun 21, 2024
cmmarslender pushed a commit that referenced this pull request Jun 21, 2024
Revert "Revert "Revert "CHIA-414 fixup datalayer benchmark"" (#18107)"

This reverts commit e87d51a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Tests Changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants