Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-645 Optimize build ancestors table. #18100

Merged
merged 13 commits into from
Jun 8, 2024
Merged

Conversation

fchirica
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@fchirica fchirica requested a review from a team as a code owner May 30, 2024 15:34
@fchirica fchirica added DataLayer Changed Required label for PR that categorizes merge commit message as "Changed" for changelog labels May 30, 2024
Copy link

coveralls-official bot commented May 31, 2024

Pull Request Test Coverage Report for Build 9375352019

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 76 of 76 (100.0%) changed or added relevant lines in 2 files are covered.
  • 643 unchanged lines in 28 files lost coverage.
  • Overall coverage decreased (-0.008%) to 90.825%

Files with Coverage Reduction New Missed Lines %
chia/_tests/wallet/cat_wallet/test_cat_wallet.py 1 99.85%
chia/cmds/dao_funcs.py 1 99.72%
chia/rpc/rpc_server.py 1 88.04%
chia/wallet/wallet_node.py 1 88.79%
chia/wallet/util/debug_spend_bundle.py 1 99.52%
chia/_tests/core/full_node/test_transactions.py 1 99.11%
chia/_tests/wallet/test_notifications.py 1 99.32%
chia/_tests/util/benchmark_cost.py 1 0.0%
chia/wallet/vc_wallet/cr_cat_wallet.py 1 97.72%
chia/wallet/dao_wallet/dao_wallet.py 1 99.89%
Totals Coverage Status
Change from base Build 9304328603: -0.008%
Covered Lines: 99431
Relevant Lines: 109416

💛 - Coveralls

@fchirica fchirica changed the title Optimize build ancestors table. CHIA-645 Optimize build ancestors table. May 31, 2024
@fchirica fchirica requested review from emlowe and altendky May 31, 2024 13:34
altendky
altendky previously approved these changes Jun 4, 2024
altendky
altendky previously approved these changes Jun 4, 2024
@fchirica fchirica added the ready_to_merge Submitter and reviewers think this is ready label Jun 6, 2024
@cmmarslender cmmarslender merged commit 9b7bb24 into main Jun 8, 2024
360 checks passed
@cmmarslender cmmarslender deleted the fc.optimize_build_ancestors branch June 8, 2024 23:26
altendky added a commit that referenced this pull request Sep 19, 2024
pmaslana pushed a commit that referenced this pull request Sep 25, 2024
* Revert "CHIA-645 Optimize build ancestors table. (#18100)"

This reverts commit 9b7bb24.

* restore tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog DataLayer ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants