Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIA-603: drop support for testnet10 #18075

Merged
merged 2 commits into from
Jun 8, 2024
Merged

CHIA-603: drop support for testnet10 #18075

merged 2 commits into from
Jun 8, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented May 24, 2024 •
edited
Loading

Purpose:

Code cleanup, removes logic not necessary for mainnet or testnet11.

This change drops supports for testnet10.

Current Behavior:

We support the behavior prior to soft-fork 2, where relative conditions were allowed on ephemeral spends.

New Behavior:

The soft-fork 2 behavior, of NO_RELATIVE_CONDITIONS_ON_EPHEMERAL, is always enabled.

@arvidn arvidn changed the title clean up some code kept around just to support testnet10 clean up some code kept around to support testnet10 May 24, 2024
@arvidn arvidn changed the title clean up some code kept around to support testnet10 CHIA-603: clean up some code kept around to support testnet10 May 24, 2024
@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label May 30, 2024
@arvidn arvidn marked this pull request as ready for review May 30, 2024 15:08
@arvidn arvidn requested a review from a team as a code owner May 30, 2024 15:08
@arvidn arvidn requested a review from altendky May 30, 2024 15:08
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented May 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9305716808

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.03%) to 90.864%
Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 80.92%
chia/rpc/rpc_server.py 1 89.04%
chia/wallet/wallet_node.py 1 88.79%
chia/server/node_discovery.py 1 79.26%
chia/server/ws_connection.py 3 87.77%
Totals Coverage Status
Change from base Build 9304328603: 0.03%
Covered Lines: 99432
Relevant Lines: 109370
💛 - Coveralls

altendky
altendky requested changes May 30, 2024
View reviewed changes
chia/_tests/util/test_testnet_overrides.py Outdated Show resolved Hide resolved
chia/_tests/util/test_replace_str_to_bytes.py Show resolved Hide resolved
chia/util/initial-config.yaml Show resolved Hide resolved
@arvidn arvidn force-pushed the cleanup-testnet10-cruft branch from 611147f to 0744cfe Compare May 30, 2024 16:08
@arvidn arvidn mentioned this pull request May 31, 2024
Merged
@arvidn
Copy link
Contributor Author

arvidn commented Jun 3, 2024

sync test can be found here

@arvidn arvidn changed the title CHIA-603: clean up some code kept around to support testnet10 CHIA-603: drop support for testnet10 Jun 7, 2024
@arvidn arvidn requested a review from emlowe June 7, 2024 10:52
@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Jun 7, 2024
@cmmarslender cmmarslender merged commit a745cb0 into main Jun 8, 2024
361 checks passed
@cmmarslender cmmarslender deleted the cleanup-testnet10-cruft branch June 8, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

@altendky altendky altendky approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arvidn @altendky @emlowe @cmmarslender