Remove ALERTS_URL and CHIA_ALERTS_PUBKEY #18027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rigidity
added
the
Changed
hoffmang9
reviewed
May 16, 2024
I think it would be cool to preserve this message standalone in the CLI and/or GUI: But if these config items aren't used in the code (nor do we plan to, since it shouldn't need to phone home for the genesis challenge anymore), imo they should be removed. Not going to die on this hill though, so if it's worth keeping around to anyone, sure |
|
This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties. |
github-actions
bot
added
the
stale-pr
emlowe
approved these changes
Jul 16, 2024
|
close and reopen for CI run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These config items are confusing and also not used anywhere in either
chia-blockchainorchia-blockchain-gui, and the only reference within the org are other config files including them.It seems after looking at the source code of
chia-blockchain==1.0.0, we used to make an API call to this endpoint, parse the JSON, and use this as a source of truth for theGENESIS_CHALLENGE.However, this is now
ConsensusConstants.GENESIS_CHALLENGE, and an API call is no longer used anywhere for this.