Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all selected_network config values when setting up simulator #17998

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

cmmarslender
Copy link
Contributor

No description provided.

@cmmarslender cmmarslender requested a review from a team as a code owner May 9, 2024 16:48
@cmmarslender cmmarslender added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label May 9, 2024
Copy link
Contributor

github-actions bot commented May 9, 2024

File Coverage Missing Lines
chia/cmds/sim_funcs.py 0.0% lines 83-90
Total Missing Coverage
8 lines 8 lines 0%

Copy link

Pull Request Test Coverage Report for Build 9020606156

Details

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • 21 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.007%) to 90.801%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/cmds/sim_funcs.py 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.5%
chia/wallet/util/wallet_sync_utils.py 1 86.54%
chia/timelord/timelord_launcher.py 1 69.92%
chia/cmds/sim_funcs.py 1 10.66%
chia/introducer/introducer.py 1 78.26%
chia/timelord/timelord.py 2 73.67%
chia/full_node/full_node.py 2 85.25%
chia/server/node_discovery.py 4 79.96%
chia/wallet/wallet_node.py 8 88.29%
Totals Coverage Status
Change from base Build 9018383795: -0.007%
Covered Lines: 98949
Relevant Lines: 108918

💛 - Coveralls

@cmmarslender cmmarslender requested a review from emlowe May 13, 2024 15:19
Copy link
Contributor

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Jun 28, 2024
@emlowe emlowe removed coverage-diff stale-pr Flagged as stale and in need of manual review labels Jul 16, 2024
@emlowe
Copy link
Contributor

emlowe commented Jul 16, 2024

coverage exemption

@Starttoaster Starttoaster merged commit 2c36263 into main Jul 16, 2024
355 of 357 checks passed
@Starttoaster Starttoaster deleted the sim-network branch July 16, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants