simplify MerkleSet by making it immutable #17861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
the
Changed
arvidn
force-pushed
the
immutable-merkle-set
branch
from
3be18a7
to
49521dc
Compare
altendky
requested changes
Apr 15, 2024
matt-o-how
previously approved these changes
Apr 15, 2024
arvidn
force-pushed
the
immutable-merkle-set
branch
from
efe81b4
to
22882c4
Compare
altendky
requested changes
Apr 15, 2024
altendky
approved these changes
Apr 16, 2024
emlowe
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
This is in preparation for the rust port of
MerkleSet, which does not haveadd_already_hashed(), but instead builds the tree in its constructor.Current Behavior:
To build a
MerkleSet, you default construct it and calladd_already_hashed()to add all leafs to it.New Behavior:
To build a
MerkleSet, you construct it with a list of all leafs.