Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only print warnings about protocol mismatches for farmer and harvester #17801

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Mar 29, 2024

In the future, maybe this should also include trusted wallets

@arvidn arvidn added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Mar 29, 2024
@arvidn arvidn marked this pull request as ready for review March 29, 2024 21:08
@arvidn arvidn requested a review from a team as a code owner March 29, 2024 21:08
Rigidity
Rigidity previously approved these changes Mar 29, 2024
Copy link
Contributor

@Rigidity Rigidity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, no more warnings

@arvidn arvidn requested a review from emlowe March 29, 2024 21:14
emlowe
emlowe previously approved these changes Mar 29, 2024
…r. In the future, maybe this should also include trusted wallets
@arvidn arvidn dismissed stale reviews from emlowe and Rigidity via 92ade30 March 29, 2024 21:21
@arvidn arvidn force-pushed the fix-protocol-mismatch-warning branch from bc1bcde to 92ade30 Compare March 29, 2024 21:21
@arvidn arvidn requested a review from Rigidity March 29, 2024 21:23
@arvidn arvidn requested a review from emlowe March 29, 2024 21:28
@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Mar 29, 2024
@pmaslana pmaslana merged commit 23288e7 into main Mar 29, 2024
310 checks passed
@pmaslana pmaslana deleted the fix-protocol-mismatch-warning branch March 29, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants