Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message conditions #17772

Merged
merged 3 commits into from
Mar 27, 2024
Merged

message conditions #17772

merged 3 commits into from
Mar 27, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Mar 23, 2024

Purpose:

  • Bump chia_rs to latest version, which introduces support for message conditions.
  • introduce soft-fork 3 to enable message conditions

proposed activation heights:

chain height
mainnet 5650000
testnet10 4465000
testnet11 641500

@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Mar 23, 2024
@arvidn arvidn changed the title Bump clvm rs 0.6.0 message conditions Mar 24, 2024
@arvidn arvidn force-pushed the bump-clvm-rs-0.6.0 branch 2 times, most recently from f78df6d to 84e4f38 Compare March 25, 2024 18:02
@arvidn arvidn marked this pull request as ready for review March 25, 2024 20:02
@arvidn arvidn requested a review from a team as a code owner March 25, 2024 20:02
@arvidn arvidn requested a review from Quexington March 25, 2024 20:02
Copy link

Pull Request Test Coverage Report for Build 8425207091

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 71 of 77 (92.21%) changed or added relevant lines in 9 files are covered.
  • 21 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.01%) to 90.849%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/wallet/conditions.py 21 27 77.78%
Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 64.98%
chia/farmer/farmer.py 1 72.67%
chia/_tests/core/util/test_lockfile.py 1 91.09%
chia/_tests/util/setup_nodes.py 1 98.35%
chia/wallet/util/wallet_sync_utils.py 1 86.6%
chia/timelord/timelord_launcher.py 1 69.92%
chia/daemon/client.py 1 84.85%
chia/farmer/farmer_api.py 2 94.4%
chia/data_layer/data_layer_wallet.py 2 91.1%
chia/server/node_discovery.py 3 79.61%
Totals Coverage Status
Change from base Build 8423807279: 0.01%
Covered Lines: 97493
Relevant Lines: 107295

💛 - Coveralls

chia/full_node/mempool_check_conditions.py Show resolved Hide resolved
chia/util/errors.py Show resolved Hide resolved
chia/wallet/conditions.py Outdated Show resolved Hide resolved
@arvidn arvidn force-pushed the bump-clvm-rs-0.6.0 branch 2 times, most recently from c087e2c to 7feaec7 Compare March 26, 2024 23:24
@arvidn arvidn requested a review from emlowe March 27, 2024 18:42
@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Mar 27, 2024
@pmaslana pmaslana merged commit c67b8bb into main Mar 27, 2024
309 checks passed
@pmaslana pmaslana deleted the bump-clvm-rs-0.6.0 branch March 27, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants