-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize insert/upsert/delete by using get_node_by_key #17765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlowe
added
the
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
label
Mar 21, 2024
emlowe
changed the title
Optimize insert/upsert/delete by using get_node_for_key
Optimize insert/upsert/delete by using get_node_by_key
Mar 21, 2024
Pull Request Test Coverage Report for Build 8389041888Details
💛 - Coveralls |
|
altendky
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quite a lot simpler, thanks!
AmineKhaldi
approved these changes
Mar 22, 2024
arvidn
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
ready_to_merge
Submitter and reviewers think this is ready
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify and optimize insert/upsert/delete (and therefore batch_update) by leveraging the newly optimized
get_node_by_key
instead of querying all the key, value pairs from the DBThis simplifies a bunch of code by eliminating the key,value hint dictionary and removes some test runs that were parameterized on that hint option