Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated GUI ref for GUI bug fix #17755

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Updated GUI ref for GUI bug fix #17755

merged 1 commit into from
Mar 25, 2024

Conversation

ChiaMineJP
Copy link
Contributor

@ChiaMineJP ChiaMineJP commented Mar 21, 2024

Update GUI submodule ref which points to c3e6838374d31b17c48fa34955fc8e886ca55861
where Chia-Network/chia-blockchain-gui#2311 is merged.

This fixes an issue where GUI launches daemon process by closing file descriptors manually in a custom bash script in Linux system.
After this PR, the GUI tries to launch daemon process by chia start daemon instead of python .../daemon/server.py

@ChiaMineJP ChiaMineJP added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Mar 21, 2024
@ChiaMineJP ChiaMineJP self-assigned this Mar 21, 2024
@ChiaMineJP ChiaMineJP force-pushed the cmj.fix-daemon-launch branch 2 times, most recently from 554a24e to 8c6b0c4 Compare March 21, 2024 15:42
@ChiaMineJP ChiaMineJP marked this pull request as ready for review March 22, 2024 13:11
@ChiaMineJP ChiaMineJP requested a review from a team as a code owner March 22, 2024 13:11
@ChiaMineJP ChiaMineJP requested a review from arvidn March 22, 2024 13:11
@ChiaMineJP ChiaMineJP marked this pull request as draft March 22, 2024 13:23
@ChiaMineJP ChiaMineJP marked this pull request as ready for review March 22, 2024 23:21
@pmaslana pmaslana merged commit 81f0451 into main Mar 25, 2024
289 checks passed
@pmaslana pmaslana deleted the cmj.fix-daemon-launch branch March 25, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants