-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHIA-299] DL separate DAT files in folders by store id #17688
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Pull Request Test Coverage Report for Build 10001146000Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Co-authored-by: Kyle Altendorf <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This PR is awaiting a coverage-diff override (or coverage of the diff) prior to merge |
|
Coverage exemption |
Adds new config setting
group_files_by_store
which then organizes all the DAT files into subfolders where the directory name is the store id. The default setting isfalse
, which means there is no change to the current behaviour on upgrade.Currently, all the DAT files are stored in one single directory.
This PR allows the user to organize their DAT files using a sub-directory for each store. The directories will be automatically created if the setting is
true
.Note that a new JSON key has been added to the plugin API (also called
group_files_by_store
) which instructs the plugin on whether to use sub-directories per store.Note that the setting will only affect new files created or downloaded. Existing files will not be automatically moved when the setting is changed to
true
. Users may manually move files.