Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-299] DL separate DAT files in folders by store id #17688

Merged
merged 48 commits into from
Aug 1, 2024

Conversation

fchirica
Copy link
Contributor

@fchirica fchirica commented Mar 12, 2024

Adds new config setting group_files_by_store which then organizes all the DAT files into subfolders where the directory name is the store id. The default setting is false, which means there is no change to the current behaviour on upgrade.

Currently, all the DAT files are stored in one single directory.

This PR allows the user to organize their DAT files using a sub-directory for each store. The directories will be automatically created if the setting is true.

Note that a new JSON key has been added to the plugin API (also called group_files_by_store) which instructs the plugin on whether to use sub-directories per store.

Note that the setting will only affect new files created or downloaded. Existing files will not be automatically moved when the setting is changed to true. Users may manually move files.

@fchirica fchirica changed the title Fc.dl separate folders DL separate DAT files in folders by store id Mar 12, 2024
@fchirica fchirica added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog DataLayer labels Mar 12, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Mar 14, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Mar 15, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Mar 15, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Mar 18, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Mar 25, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

coveralls-official bot commented Jul 15, 2024

Pull Request Test Coverage Report for Build 10001146000

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 167 of 252 (66.27%) changed or added relevant lines in 6 files are covered.
  • 1948 unchanged lines in 78 files lost coverage.
  • Overall coverage decreased (-0.1%) to 90.869%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/data_layer/data_layer.py 14 19 73.68%
chia/data_layer/data_layer_server.py 0 10 0.0%
chia/data_layer/download_data.py 52 67 77.61%
chia/data_layer/s3_plugin_service.py 0 55 0.0%
Files with Coverage Reduction New Missed Lines %
chia/_tests/wallet/test_wallet_retry.py 1 98.55%
chia/types/eligible_coin_spends.py 1 98.06%
chia/_tests/wallet/db_wallet/test_dl_wallet.py 1 99.42%
chia/_tests/wallet/db_wallet/test_dl_offers.py 1 99.24%
chia/util/keyring_wrapper.py 1 73.83%
chia/daemon/keychain_proxy.py 1 72.57%
chia/full_node/mempool.py 1 99.71%
chia/_tests/wallet/dao_wallet/test_dao_wallets.py 1 99.95%
chia/data_layer/data_layer_server.py 1 0.0%
chia/farmer/farmer.py 1 72.23%
Totals Coverage Status
Change from base Build 9719381064: -0.1%
Covered Lines: 72256
Relevant Lines: 79499

💛 - Coveralls

@emlowe emlowe requested a review from altendky July 16, 2024 17:29
chia/data_layer/data_layer.py Outdated Show resolved Hide resolved
chia/_tests/core/data_layer/test_data_store.py Outdated Show resolved Hide resolved
chia/_tests/core/data_layer/test_data_store.py Outdated Show resolved Hide resolved
chia/_tests/core/data_layer/test_data_store.py Outdated Show resolved Hide resolved
chia/data_layer/download_data.py Outdated Show resolved Hide resolved
chia/data_layer/download_data.py Outdated Show resolved Hide resolved
chia/data_layer/download_data.py Outdated Show resolved Hide resolved
chia/data_layer/s3_plugin_service.py Outdated Show resolved Hide resolved
chia/data_layer/download_data.py Outdated Show resolved Hide resolved
chia/data_layer/download_data.py Outdated Show resolved Hide resolved
altendky
altendky previously approved these changes Jul 19, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 24, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 31, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Starttoaster
Copy link
Contributor

This PR is awaiting a coverage-diff override (or coverage of the diff) prior to merge

Copy link
Contributor

@emlowe
Copy link
Contributor

emlowe commented Aug 1, 2024

Coverage exemption

@Starttoaster Starttoaster merged commit 74b14ce into main Aug 1, 2024
374 of 375 checks passed
@Starttoaster Starttoaster deleted the fc.dl_separate_folders branch August 1, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog DataLayer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants