Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize DL get key by node. #17680

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Optimize DL get key by node. #17680

merged 5 commits into from
Mar 15, 2024

Conversation

fchirica
Copy link
Contributor

@fchirica fchirica commented Mar 8, 2024

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@fchirica fchirica requested a review from a team as a code owner March 8, 2024 21:52
@fchirica fchirica added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog DataLayer labels Mar 8, 2024
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 8211363880

Details

  • 52 of 52 (100.0%) changed or added relevant lines in 2 files are covered.
  • 27 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.009%) to 91.017%
Files with Coverage Reduction New Missed Lines %
chia/data_layer/data_store.py 1 95.26%
chia/timelord/timelord_launcher.py 1 69.77%
tests/core/util/test_lockfile.py 1 91.09%
chia/timelord/timelord.py 2 73.67%
chia/data_layer/data_layer.py 2 83.93%
chia/server/node_discovery.py 3 79.26%
chia/plotters/madmax.py 3 49.4%
chia/introducer/introducer_api.py 5 78.26%
chia/full_node/full_node.py 9 84.98%
Totals Coverage Status
Change from base Build 8195768649: -0.009%
Covered Lines: 97586
Relevant Lines: 107181
💛 - Coveralls

emlowe
emlowe requested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@emlowe emlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use name node_key_index

emlowe
emlowe previously approved these changes Mar 14, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Mar 14, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Mar 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@pmaslana pmaslana merged commit d4948af into main Mar 15, 2024
284 checks passed
@pmaslana pmaslana deleted the fc.optimize_get_key branch March 15, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

@altendky altendky Awaiting requested review from altendky

@AmineKhaldi AmineKhaldi Awaiting requested review from AmineKhaldi

Assignees
No one assigned
Labels
DataLayer Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fchirica @AmineKhaldi @emlowe @pmaslana