Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turned concatenation of strings to f-strings (from eukub) #17676

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Mar 8, 2024

Duplication of #17067 with signed commits

ack to @eukub

@emlowe emlowe requested a review from a team as a code owner March 8, 2024 15:51
@emlowe emlowe requested a review from altendky March 8, 2024 15:51
@emlowe emlowe added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Mar 8, 2024
Copy link

Pull Request Test Coverage Report for Build 8205725445

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 24 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.1%) to 91.151%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/seeder/dns_server.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
chia/wallet/util/wallet_sync_utils.py 1 86.12%
chia/rpc/wallet_rpc_api.py 1 89.19%
chia/wallet/wallet_node.py 3 88.15%
chia/server/node_discovery.py 3 79.26%
chia/introducer/introducer_api.py 5 78.26%
chia/full_node/full_node.py 11 84.82%
Totals Coverage Status
Change from base Build 8195768649: 0.1%
Covered Lines: 84112
Relevant Lines: 92256

💛 - Coveralls

@pmaslana
Copy link
Contributor

This PR has the coverage-diff label. Could someone from the engineering team review the coverage diff and remove the label to approve of the diff, or write tests to cover that diff if it should be tested?

@altendky
Copy link
Contributor

Done. Thanks for the attention to detail.

Copy link
Contributor

File Coverage Missing Lines
chia/seeder/dns_server.py 0.0% lines 36, 468
Total Missing Coverage
2 lines 2 lines 0%

@pmaslana pmaslana merged commit 4e90ca2 into main Mar 15, 2024
282 of 284 checks passed
@pmaslana pmaslana deleted the EL.eukub.concat-to-fstring branch March 15, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants