Move get_network_info endpoint to the base rpc server class #17662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmmarslender
added
the
Changed
cmmarslender
changed the title
altendky
requested changes
Mar 7, 2024
…pe implementations from wallet/full_node Enables also getting network info from other RPC servers (crawler, etc)
Co-authored-by: Kyle Altendorf <[email protected]>
cmmarslender
force-pushed
the
shared-net-info
branch
from
3cb3321
to
ce1bbb1
Compare
altendky
approved these changes
Mar 7, 2024
emlowe
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed network info when running crawler. The method was already duplicated on the full_node and wallet rpc servers, so seemed more appropriate to move to the base rpc server class. Now we can get network info from any running rpc server.