Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parameter #17598

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Remove unused parameter #17598

merged 6 commits into from
Feb 23, 2024

Conversation

aqk
Copy link
Contributor

@aqk aqk commented Feb 22, 2024

Purpose:

Better implementation of #17594

Current Behavior:

New Behavior:

Testing Notes:

@aqk aqk added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Feb 22, 2024
@aqk aqk requested a review from a team as a code owner February 22, 2024 20:34
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/plotnft_funcs.py 0.0% lines 109, 275
Total Missing Coverage
27 lines 2 lines 92%

Copy link
Contributor

@emlowe emlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - good cleanup

@emlowe
Copy link
Contributor

emlowe commented Feb 23, 2024

coverage exemption for old uncovered code

@Starttoaster Starttoaster merged commit cc5a5a9 into main Feb 23, 2024
276 of 277 checks passed
@Starttoaster Starttoaster deleted the ak.get_transaction_typo branch February 23, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants