Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testnet11 constants to config if missing when configuring to run on testnet #17568

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Add testnet11 constants to config if missing when configuring to run on testnet #17568

merged 4 commits into from
Feb 15, 2024

Conversation

cmmarslender
Copy link
Contributor

No description provided.

@cmmarslender cmmarslender requested a review from a team as a code owner February 15, 2024 19:02
@cmmarslender cmmarslender added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Feb 15, 2024
arvidn
arvidn approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I kind of got the impression we weren't doing this though

@Starttoaster Starttoaster merged commit f499f9d into release/2.2.0 Feb 15, 2024
590 of 591 checks passed
@Starttoaster Starttoaster deleted the testnet11-config branch February 15, 2024 21:15
@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/configure.py 22.2% lines 113-117, 121-122
Total Missing Coverage
9 lines 7 lines 22%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

@altendky altendky altendky approved these changes

@emlowe emlowe Awaiting requested review from emlowe

Assignees
No one assigned
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog coverage-diff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmmarslender @altendky @arvidn @Starttoaster