Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative plot sync durations not crashing the harvester #17444

Merged

Conversation

felixbrucker
Copy link
Contributor

Purpose:

Ensure negative durations do not crash the harvester.

Current Behavior:

A negative duration will crash the harvester.

New Behavior:

A negative duration will not crash the harvester.

Side note:

I don't know why the bug report was closed without any comment half a year ago, but this issue was present since 1.3.4 and still is in the latest chia version as of writing. This occurring might be rare but it does happen and should not just be closed, especially when the fix is a one liner.

Fixes #15027

@felixbrucker felixbrucker requested a review from a team as a code owner January 31, 2024 10:35
@emlowe emlowe added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jan 31, 2024
Copy link

Pull Request Test Coverage Report for Build 7735134136

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • 764 unchanged lines in 50 files lost coverage.
  • Overall coverage decreased (-0.05%) to 90.842%

Files with Coverage Reduction New Missed Lines %
chia/daemon/server.py 1 87.31%
chia/data_layer/download_data.py 1 71.04%
chia/plotters/madmax.py 1 50.0%
chia/server/start_service.py 1 93.3%
chia/util/condition_tools.py 1 91.8%
chia/wallet/trade_manager.py 1 96.26%
chia/wallet/util/wallet_sync_utils.py 1 78.14%
tests/core/util/test_file_keyring_synchronization.py 1 97.1%
tests/farmer_harvester/test_farmer.py 1 99.68%
tests/fee_estimation/test_fee_estimation_unit_tests.py 1 99.06%
Totals Coverage Status
Change from base Build 7726492794: -0.05%
Covered Lines: 96340
Relevant Lines: 106026

💛 - Coveralls

@Starttoaster Starttoaster merged commit 23e003a into Chia-Network:main Feb 2, 2024
260 checks passed
@felixbrucker felixbrucker deleted the fix-negative-plot-sync-durations branch February 2, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Harvester Crashes on plot refresh - Unrecoverable without restart
3 participants