use rust version of SpendBundle

[arvidn]

Purpose:

This is a step towards validating transactions in threads. The python <-> rust boundary will need to move to make the SpendBundle live on the rust side, to allow moving it to the worker thread and back.

Current Behavior:

SpendBundle is a python type.

New Behavior:

SpendBundle is a rust type.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[Rigidity]

I'm going to take a look at wallet performance with this PR, given the recent weight proof debacle. Otherwise, looks good to me.

[coveralls-official]

Pull Request Test Coverage Report for Build 9485741536

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 10 of 13 (76.92%) changed or added relevant lines in 7 files are covered.
• 30 unchanged lines in 12 files lost coverage.
• Overall coverage decreased (-0.009%) to 90.886%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
chia/wallet/trading/offer.py	1	4	25.0%

Files with Coverage Reduction	New Missed Lines	%
chia/daemon/keychain_proxy.py	1	72.57%
chia/farmer/farmer.py	1	72.23%
chia/wallet/util/wallet_sync_utils.py	1	86.54%
chia/timelord/timelord_launcher.py	1	69.34%
chia/daemon/client.py	1	73.33%
chia/daemon/server.py	1	83.22%
chia/full_node/full_node_api.py	2	81.66%
chia/rpc/rpc_server.py	3	87.71%
chia/wallet/wallet_node.py	3	88.79%
chia/_tests/core/util/test_lockfile.py	4	89.47%

Totals
Change from base Build 9484102110:	-0.009%
Covered Lines:	99991
Relevant Lines:	109964

---

💛 - Coveralls

[wjblanke]

aok

[Starttoaster]

Waiting on passing CI, resolved conversations, and coverage diff resolution/override

[Rigidity]

With Rust spend bundle:
Total time: 3.2067s
Total amount: 6194000
Total coin spends: 12400000

With Python spend bundle:
Total time: 3.2434s
Total amount: 6194000
Total coin spends: 12400000

from time import monotonic
from typing import List
from chia_rs import Coin, CoinSpend, G2Element, Program, SpendBundle
from chia_rs.sized_ints import uint64
from chia_rs.sized_bytes import bytes32

from chia.util.hash import std_hash
from chia.wallet.nft_wallet.nft_puzzles import STANDARD_PUZZLE_MOD


FAKE_PUZZLE = Program.from_program(STANDARD_PUZZLE_MOD)
FAKE_PUZZLE_HASH = bytes32(b"0" * 32)


def make_spend_bundle(spend_count: int) -> SpendBundle:
    coin_spends: List[CoinSpend] = []

    for i in range(spend_count):
        coin = Coin(std_hash(i.to_bytes(4, "big")), FAKE_PUZZLE_HASH, uint64(i))
        puzzle_reveal = FAKE_PUZZLE
        solution = Program.to([[51, FAKE_PUZZLE_HASH, i]])
        coin_spends.append(CoinSpend(coin, puzzle_reveal, solution))

    return SpendBundle(coin_spends, G2Element.generator())


def bench_spend_bundles():
    initial = monotonic()
    total_amount = 0
    spend_count = 0

    for i in range(1, 16):
        start = monotonic()
        spend_bundle = make_spend_bundle(i * 100)
        for cs in spend_bundle.coin_spends:
            spend_count += len(spend_bundle.coin_spends)
            _ = spend_bundle.coin_spends
            total_amount += cs.coin.amount
        end = monotonic()
        print(f"{i * 100} coin spends with O(n^2) loop took {end - start:.4f}s")

    final = monotonic()
    print(f"Total time: {final - initial:.4f}s")
    print(f"Total amount: {total_amount}")
    print(f"Total coin spends: {spend_count}")


if __name__ == "__main__":
    bench_spend_bundles()

[Rigidity]

I don't think we need to worry about coin_solutions compatibility anymore. Resolved my comments.

[arvidn]

the streamable format of Offer was missing test coverage before this change

[github-actions]

File	Coverage	Missing Lines
chia/wallet/trading/offer.py	25.0%	lines 687, 691-692

Total	Missing	Coverage
13 lines	3 lines	76%

[Starttoaster]

Re-removing coverage diff since Arvid overrid it earlier and a new CI run added it back.