Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use rust implementation of CoinSpend #17408

Merged
merged 1 commit into from
Jan 29, 2024
Merged

use rust implementation of CoinSpend #17408

merged 1 commit into from
Jan 29, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Jan 26, 2024

Purpose:

transition the CoinSpend class to use the rust counterpart.

Current Behavior:

New Behavior:

Testing Notes:

@arvidn arvidn requested a review from Rigidity January 26, 2024 12:55
@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Jan 26, 2024
Rigidity
Rigidity approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@Rigidity Rigidity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arvidn arvidn marked this pull request as ready for review January 26, 2024 14:50
@arvidn arvidn requested a review from a team as a code owner January 26, 2024 14:50
@arvidn arvidn requested a review from emlowe January 29, 2024 14:04
@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Jan 29, 2024
@Starttoaster Starttoaster merged commit fdd480d into main Jan 29, 2024
266 of 267 checks passed
@Starttoaster Starttoaster deleted the rust-coin-spend branch January 29, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

@Rigidity Rigidity Rigidity approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arvidn @emlowe @Rigidity @Starttoaster