Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Could not find parent coin" error log to print hex and not bytes #17373

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

hoffmang9
Copy link
Member

Purpose:

Improve the usability of wallet logs by using human readable output instead of a byte array.

Current Behavior:

2024-01-05T14:18:36.525 wallet chia.wallet.wallet_state_manager: WARNING Could not find a parent coin with ID: b'y;\x89\xd5bk8/\xc02_\xa2\\\x14\xbb.\x03H[\x06\xf6\xb7t\x1d\x17\n\x8b\xd0\xed\x0b\xfd\x82'

New Behavior:

2024-01-05T14:18:36.525 wallet chia.wallet.wallet_state_manager: WARNING Could not find a parent coin with ID: 793b89d5626b382fc0325fa25c14bb2e03485b06f6b7741d170a8bd0ed0bfd82

Testing Notes:

@hoffmang9 hoffmang9 added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Logging Change output to .chia/NETWORK/log/debug.log labels Jan 21, 2024
@hoffmang9 hoffmang9 requested a review from a team as a code owner January 21, 2024 23:43
@hoffmang9 hoffmang9 changed the title Update "Cloud not find parent coin" error log to print hex and not bytes Update "Could not find parent coin" error log to print hex and not bytes Jan 21, 2024
Copy link

Pull Request Test Coverage Report for Build 7604585847

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 122 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-0.08%) to 90.567%

Files with Coverage Reduction New Missed Lines %
chia/introducer/introducer.py 1 78.26%
chia/plotters/plotters.py 1 90.94%
chia/rpc/rpc_server.py 1 88.4%
tests/core/util/test_file_keyring_synchronization.py 1 97.1%
tests/simulation/test_simulation.py 1 96.52%
chia/timelord/timelord_api.py 2 87.85%
chia/timelord/timelord_launcher.py 2 69.77%
chia/farmer/farmer_api.py 3 92.73%
chia/full_node/full_node.py 3 85.07%
chia/server/node_discovery.py 3 79.9%
Totals Coverage Status
Change from base Build 7601805424: -0.08%
Covered Lines: 94762
Relevant Lines: 104585

💛 - Coveralls

@Starttoaster Starttoaster merged commit 8baead2 into main Jan 31, 2024
267 checks passed
@Starttoaster Starttoaster deleted the hoffmang9-patch-1 branch January 31, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Logging Change output to .chia/NETWORK/log/debug.log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants