Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve timelord skip peak logic. #17302

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

fchirica
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@fchirica fchirica requested a review from a team as a code owner January 11, 2024 19:06
@fchirica fchirica added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog and removed Changed Required label for PR that categorizes merge commit message as "Changed" for changelog labels Jan 11, 2024
Copy link
Contributor

@emlowe emlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on last conversation with Almog - there isn't much downside to merging this into main

Copy link
Contributor

File Coverage Missing Lines
chia/timelord/timelord_api.py 83.3% lines 52, 55
Total Missing Coverage
12 lines 2 lines 83%

Copy link

Pull Request Test Coverage Report for Build 7493379578

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • -2 of 12 (83.33%) changed or added relevant lines in 1 file are covered.
  • 38 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.496%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/timelord/timelord_api.py 10 12 83.33%
Files with Coverage Reduction New Missed Lines %
tests/util/setup_nodes.py 1 98.35%
tests/wallet/cat_wallet/test_cat_wallet.py 1 99.86%
chia/rpc/rpc_server.py 2 88.05%
chia/server/node_discovery.py 3 79.38%
chia/wallet/wallet_node.py 7 87.94%
tests/core/util/test_lockfile.py 24 77.73%
Totals Coverage Status
Change from base Build 7491469029: -0.02%
Covered Lines: 94473
Relevant Lines: 104350

💛 - Coveralls

@emlowe
Copy link
Contributor

emlowe commented Jan 31, 2024

Coverage diff exemption

@Starttoaster Starttoaster merged commit 221dab4 into main Feb 1, 2024
267 of 269 checks passed
@Starttoaster Starttoaster deleted the fc.improve_dl_skip_peak_logic branch February 1, 2024 01:28
@arvidn
Copy link
Contributor

arvidn commented Feb 1, 2024

I was under the impression that @fchirica abandoned this PR in favor of @almogdepaz's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants