Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure we set max_sync_wait to 0 in all tests #16771

Merged
merged 1 commit into from
Nov 6, 2023
Merged

make sure we set max_sync_wait to 0 in all tests #16771

merged 1 commit into from
Nov 6, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Nov 3, 2023

Purpose:

Some tests may still wait the full 30 seconds before starting sync.

@arvidn arvidn requested a review from a team as a code owner November 3, 2023 21:44
@arvidn arvidn added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Tests Changes to tests labels Nov 3, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023

File Coverage Missing Lines
chia/simulator/setup_nodes.py 87.5% lines 350
Total Missing Coverage
9 lines Unknown 88%

@arvidn arvidn requested a review from wjblanke November 5, 2023 13:05
wjblanke
wjblanke approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok!

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Nov 6, 2023
@cmmarslender cmmarslender merged commit 9622331 into main Nov 6, 2023
253 of 255 checks passed
@cmmarslender cmmarslender deleted the max-sync-wait branch November 6, 2023 13:02
@arvidn arvidn mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

@almogdepaz almogdepaz almogdepaz approved these changes

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog ready_to_merge Submitter and reviewers think this is ready Tests Changes to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arvidn @wjblanke @almogdepaz @cmmarslender