Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync no farmer #16698

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Sync no farmer #16698

merged 2 commits into from
Oct 26, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Oct 26, 2023

Purpose:

As part of the patch to fix deep-reorgs, it was discovered that one of the tests would not trigger a reorg sync unless a new block was farmed. That's not the intention, so I added this test to ensure a normal, catch-up, sync can be triggered without a new farm being farmed.

In order to make the tests not take too long, I cherry-picked one of the commits from the deep-reorg PR to make the delay configurable, of how long to wait to receive 3 peers with the same peak. This is set to 1 seconds in the tests now.

There is no change in behavior, except the delay is configurable, still defaults to 30 seconds.

@arvidn arvidn requested a review from a team as a code owner October 26, 2023 11:32
@arvidn arvidn added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Tests Changes to tests labels Oct 26, 2023
@arvidn arvidn requested a review from wjblanke October 26, 2023 18:49
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 6656572492

  • 28 of 28 (100.0%) changed or added relevant lines in 3 files are covered.
  • 88 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.09%) to 90.015%

Files with Coverage Reduction New Missed Lines %
chia/server/node_discovery.py 1 78.01%
chia/timelord/timelord_launcher.py 1 69.77%
chia/full_node/full_node.py 2 86.1%
chia/full_node/weight_proof.py 2 90.81%
chia/timelord/timelord_api.py 2 87.85%
chia/server/server.py 4 81.45%
chia/full_node/full_node_api.py 7 77.59%
chia/timelord/timelord_state.py 20 69.47%
chia/timelord/timelord.py 49 73.85%
Totals Coverage Status
Change from base Build 6656422893: -0.09%
Covered Lines: 93183
Relevant Lines: 103459

💛 - Coveralls

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Oct 26, 2023
@cmmarslender cmmarslender merged commit 709190b into main Oct 26, 2023
253 checks passed
@cmmarslender cmmarslender deleted the sync-no-farmer branch October 26, 2023 20:34
@arvidn arvidn mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready Tests Changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants