Get block spends #16451
Merged
Get block spends #16451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
the
Fixed
arvidn
force-pushed
the
get_block_spends
branch
from
72376c4
to
d29a001
Compare
|
the missing test coverage is in a benchmark, which we don't instrument |
|
cameroncooper
previously approved these changes
Oct 6, 2023
arvidn
added
ready_to_merge
emlowe
approved these changes
Oct 10, 2023
arvidn
added a commit
that referenced
this pull request
Oct 13, 2023
cmmarslender
pushed a commit
that referenced
this pull request
Oct 16, 2023
This was referenced Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
The
get_block_spendsRPC will not currently work after the hard fork. This can be demonstrated on testnet10 where the hard fork has already activated.This patch fixes
get_block_spendsand also improves the reliability of theget_puzzle_and_solutionRPC, which currently does take the hard fork serialization format into account, but no other hard- or soft fork rule changes.This change incorporates part of a patch from @freddiecoleman .
Current Behavior:
get_block_spendsfail after the hard fork.get_puzzle_and_solutionmay fail if certain new soft-fork features are used on the block in question.New Behavior:
get_block_spendshave the intended behavior after the hard fork.get_puzzle_and_solutionhave the intended behavior regardless of which block it's called on.Testing Notes:
The test for
get_block_spendswas extended to be run for each soft-fork version and the hard fork.