Wallet workaround for python issue 97641 and update anyio for issue 589 #16408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjblanke
added
the
Fixed
wjblanke
changed the title
arvidn
approved these changes
Sep 25, 2023
This was referenced Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Improve test reliability by adding Arvid's workaround for python issue 97641 to wallet
python/cpython#97641
and updating anyio to 4.0.0 for timeout after success
agronholm/anyio#589
Current Behavior:
ERROR tests/wallet/cat_wallet/test_cat_wallet.py::TestCATWallet::test_cat_spend[ConsensusMode.SOFT_FORK3-True] - PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\Users\RUNNER~1\AppData\Local\Temp\tmpx8x4fkli\test-wallet-db-None-270976397.sqlite'
ERROR tests/wallet/cat_wallet/test_cat_wallet.py::TestCATWallet::test_cat_spend[ConsensusMode.SOFT_FORK3-False] - MemoryError
Tasks not finished etc
Plus loads of timeouts?!?
New Behavior:
This flakiness removed
Testing Notes:
Watch CI results