Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump test_mempool_update_performance benchmark duration from 0.1 to 0.15 #16353

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Bump test_mempool_update_performance benchmark duration from 0.1 to 0.15 #16353

merged 1 commit into from
Sep 18, 2023

Conversation

AmineKhaldi
Copy link
Contributor

Addresses instances like:
FAILED tests/core/mempool/test_mempool_performance.py::TestMempoolPerformance::test_mempool_update_performance[ConsensusMode.PLAIN] - AssertionError: 0.12349152299998423 seconds not less than 0.1 seconds ( 123 % )

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Sep 18, 2023
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner September 18, 2023 11:08
@AmineKhaldi AmineKhaldi self-assigned this Sep 18, 2023
arvidn
arvidn approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know if anything changed in the mempool recently? are we confident this slow-down is a property of the benchmark runners and not the code itself?

@cmmarslender cmmarslender merged commit 8256de5 into Chia-Network:main Sep 18, 2023
201 of 202 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees

@AmineKhaldi AmineKhaldi

Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmineKhaldi @arvidn @cmmarslender