Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate harvester_rpc_client.py #15379

Merged

Conversation

AmineKhaldi
Copy link
Contributor

No description provided.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels May 24, 2023
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner May 24, 2023 16:24
@AmineKhaldi AmineKhaldi self-assigned this May 24, 2023
@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 5071099994

  • 1 of 13 (7.69%) changed or added relevant lines in 1 file are covered.
  • 15 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.1%) to 85.264%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/rpc/harvester_rpc_client.py 1 13 7.69%
Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node.py 1 86.25%
tests/simulation/test_simulation.py 1 96.97%
chia/timelord/timelord.py 2 73.11%
chia/full_node/full_node_api.py 3 77.22%
chia/server/node_discovery.py 3 78.11%
chia/wallet/wallet_node.py 5 86.25%
Totals Coverage Status
Change from base Build 5063489378: 0.1%
Covered Lines: 76105
Relevant Lines: 89083

💛 - Coveralls

emlowe
emlowe previously approved these changes May 24, 2023
@emlowe
Copy link
Contributor

emlowe commented May 24, 2023

HarvesterRpcClient doesn't have (many) tests, so the added code triggers coverage diff.
Note: add_plot_directory testing is currently a known skip
It might be worthwhile to add in some basic tests for this class.

@github-actions github-actions bot added merge_conflict Branch has conflicts that prevent merge to main labels May 24, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

2 similar comments
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@AmineKhaldi AmineKhaldi force-pushed the annotate_harvester_rpc_client branch from 75d4c0c to e0b64b5 Compare June 21, 2023 18:00
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jun 21, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@AmineKhaldi AmineKhaldi requested a review from emlowe June 21, 2023 20:40
@wallentx
Copy link
Contributor

Failure. Coverage is below 100%.

Diff Coverage
Diff: origin/main...HEAD, staged and unstaged changes

chia/rpc/harvester_rpc_client.py (7.7%): Missing lines 24,26-27,30,32-33,36,38-39,42,44-45

Total: 13 lines
Missing: 12 lines
Coverage: 7%

@emlowe
Copy link
Contributor

emlowe commented Jun 21, 2023

Approved exception to code coverage as this is strictly a typing improvement

@wallentx wallentx merged commit 1904baf into Chia-Network:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants