Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where chia wallet did transfer command mistreats the type of fee #15138

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

ChiaMineJP
Copy link
Contributor

@ChiaMineJP ChiaMineJP commented Apr 27, 2023

Purpose:

Fixed an issue found on newly added chia wallet did transfer CLI command

Current Behavior:

When you run chia wallet did transfer --fee 0.001, 0.001 is treated as 0.001 mojo while it should be 0.001 xch.

New Behavior:

In the case above, 0.001 will be treated as 0.001 xch (0.001 * 10^12 mojo) as everyone expects.

Testing Notes:

@ChiaMineJP ChiaMineJP added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Apr 27, 2023
@ChiaMineJP ChiaMineJP requested a review from a team as a code owner April 27, 2023 11:14
@ChiaMineJP ChiaMineJP linked an issue Apr 27, 2023 that may be closed by this pull request
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label May 11, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Jun 25, 2023
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jan 17, 2024
@ChiaMineJP ChiaMineJP removed the stale-pr Flagged as stale and in need of manual review label Jan 17, 2024
@ChiaMineJP ChiaMineJP requested review from emlowe and removed request for trepca January 17, 2024 16:44
@ChiaMineJP ChiaMineJP self-assigned this Jan 17, 2024
Copy link

Pull Request Test Coverage Report for Build 7559039143

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 90.644%

Totals Coverage Status
Change from base Build 7558301977: 0.06%
Covered Lines: 94862
Relevant Lines: 104617

💛 - Coveralls

@cmmarslender cmmarslender merged commit d4ff6ef into main Jan 19, 2024
265 checks passed
@cmmarslender cmmarslender deleted the cmj.fix-did-transfer branch January 19, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DID transfer from CLI, --fee error [Bug]
3 participants