Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DL: stop using fee config setting and remove from initial config #13374

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Sep 7, 2022

Stop using DataLayer fee setting in config and remove the setting from the initial config. Note any previous installs will still have a fee setting, but it is ignored
Tests are updated to specify the old default fee in order to keep reference offer data the same

Fixes #13365

Draft for:

  • Discussion with Michael.

@emlowe emlowe requested a review from altendky September 7, 2022 21:45
@emlowe emlowe marked this pull request as draft September 8, 2022 01:08
@emlowe emlowe marked this pull request as ready for review September 8, 2022 01:28
@altendky altendky marked this pull request as draft September 8, 2022 14:16
@emlowe emlowe marked this pull request as ready for review September 8, 2022 15:10
@altendky altendky marked this pull request as draft September 8, 2022 15:12
Copy link
Contributor

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to discuss with Michael.

@altendky altendky changed the base branch from release/1.6.0 to main September 13, 2022 03:21
@altendky altendky added the sql Issues with SQL/SQLite label Sep 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Nov 6, 2022
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 17, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the stale-pr Flagged as stale and in need of manual review label Oct 13, 2023
@emlowe emlowe added DataLayer and removed sql Issues with SQL/SQLite labels Nov 9, 2023
Copy link
Contributor

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Dec 25, 2023
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Mar 25, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@emlowe emlowe added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog and removed stale-pr Flagged as stale and in need of manual review labels Mar 25, 2024
@emlowe emlowe marked this pull request as ready for review March 26, 2024 16:54
@emlowe emlowe requested a review from a team as a code owner March 26, 2024 16:54
Copy link

Pull Request Test Coverage Report for Build 8424357798

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 35 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.821%

Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.52%
chia/full_node/full_node_api.py 1 79.32%
chia/_tests/util/setup_nodes.py 1 98.35%
chia/wallet/util/wallet_sync_utils.py 1 86.6%
chia/data_layer/data_layer_wallet.py 2 91.1%
chia/rpc/rpc_server.py 4 87.67%
chia/full_node/weight_proof.py 4 90.73%
chia/full_node/full_node.py 4 85.12%
chia/wallet/wallet_node.py 5 88.34%
chia/_tests/core/util/test_lockfile.py 5 88.66%
Totals Coverage Status
Change from base Build 8423807279: -0.02%
Covered Lines: 97419
Relevant Lines: 107238

💛 - Coveralls

Copy link
Contributor

@TheLastCicada TheLastCicada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right way to go. No known datalayer apps rely on the default fee.

Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@pmaslana pmaslana merged commit 5dad9f2 into main Mar 27, 2024
291 of 292 checks passed
@pmaslana pmaslana deleted the EL.defaultfee branch March 27, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog DataLayer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove or Set to 0 DataLayer default fee
5 participants